fix wrong confidence interval shape in mt_coherence()#36
Open
Xunius wants to merge 1 commit intokrischer:masterfrom
Open
fix wrong confidence interval shape in mt_coherence()#36Xunius wants to merge 1 commit intokrischer:masterfrom
Xunius wants to merge 1 commit intokrischer:masterfrom
Conversation
In `multitaper.py`, the `mt_coherence()` function assigned an empty array for the desired confidence interval using `mt.empty(nf, 2)` at line 600. This gave an 1d complex array of length nf, because the argument `2` is passed to the `complex=False` kwarg of the `mt.empty()` method. The correct call should be `mt.empty((nf, 2))`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
multitaper.py, themt_coherence()function assigned an empty arrayfor the desired confidence interval using
mt.empty(nf, 2)at line 600.This gave an 1d complex array of length nf, because the argument
2is passedto the
complex=Falsekwarg of themt.empty()method.The correct call should be
mt.empty((nf, 2))Related to issue #32