Skip to content

fix: change status update order for gracefullypausedtime update #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matteogastaldello merged 1 commit into from
Dec 23, 2025
Merged

fix: change status update order for gracefullypausedtime update #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions internal/composition/composition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,18 +542,8 @@ func (h *handler) Update(ctx context.Context, mg *unstructured.Unstructured) err
message: "Composition values updated",
chartURL: pkg.URL,
chartVersion: pkg.Version,
conditionType: ConditionTypeAvailable,
}

if compositionMeta.IsGracefullyPaused(mg) {
statusOpts.conditionType = ConditionTypeReconcileGracefullyPaused
compositionMeta.SetGracefullyPausedTime(mg, time.Now())
log.Debug("Composition gracefully paused.")
h.eventRecorder.Event(mg, event.Normal(reasonReconciliationGracefullyPaused, "Update", "Reconciliation paused via the gracefully paused annotation."))
} else {
statusOpts.conditionType = ConditionTypeAvailable
meta.RemoveAnnotations(mg, compositionMeta.AnnotationKeyReconciliationGracefullyPausedTime)
}

err = setStatus(mg, statusOpts)
if err != nil {
return fmt.Errorf("setting status: %w", err)
Expand All @@ -566,7 +556,19 @@ func (h *handler) Update(ctx context.Context, mg *unstructured.Unstructured) err
if err != nil {
return fmt.Errorf("updating cr status with values: %w", err)
}
_, err = tools.Update(ctx, mg, updateOpts)

if compositionMeta.IsGracefullyPaused(mg) {
statusOpts.conditionType = ConditionTypeReconcileGracefullyPaused
compositionMeta.SetGracefullyPausedTime(mg, time.Now())
log.Debug("Composition gracefully paused.")
h.eventRecorder.Event(mg, event.Normal(reasonReconciliationGracefullyPaused, "Update", "Reconciliation paused via the gracefully paused annotation."))

} else {
statusOpts.conditionType = ConditionTypeAvailable
meta.RemoveAnnotations(mg, compositionMeta.AnnotationKeyReconciliationGracefullyPausedTime)
}

mg, err = tools.Update(ctx, mg, updateOpts)
if err != nil {
return fmt.Errorf("updating cr with values: %w", err)
}
Expand Down
Loading