Add stale prs#1053
Open
CsatariGergely wants to merge 3 commits into
Open
Conversation
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
❌ Deploy Preview for kpt-porch failed. Why did it fail? →
|
Contributor
There was a problem hiding this comment.
⚠️ Not ready to approve
The new documentation contains typos/grammar issues and includes potentially misleading wording about stale PR closure (implying automation without evidence).
Pull request overview
Updates the contributor guide’s PR review/merge expectations by documenting the agreed approval requirements and introducing a “stale PR” policy.
Changes:
- Reflowed/clarified the “Reviews of Your PR” checklist formatting.
- Added an explicit requirement for approvals from both the contributors and maintainers teams before merging.
- Added guidance for handling “stale PRs” (closure after a period of inactivity).
File summaries
| File | Description |
|---|---|
| docs/content/en/docs/12_contributing/code-contribution/_index.md | Documents new PR approval rules and adds a stale PR policy section in the contribution guide. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 3
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
dosubot
Bot
added
the
size:S
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Assisted-by: GitHub Copilot: Claude Haiku 4.5 Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.