Create db indexing for upstream ref

[kushnaidu]

Title

Create db indexing for upstream ref, so that, looking up for references is quick.

---

Description

• What changed:

1. Added a new upstream_ref_name column to the package_revisions table that stores the upstream package revision name extracted from clone/upgrade tasks.
2. Replaced the regex-based query in findUpstreamRefsFromDB (which scanned tasks::text with a pattern match) with a simple equality check on the new indexed column.
3. Added a backfillUpstreamRefName function that runs on startup to populate the column for existing rows.
4. The backfill code now uses smaller transactions with limits to avoid consuming too much memory on the system at startup if a lot of DB rows require an update.
5. Added 5 B-tree indexes covering query paths: upstream ref lookup, revision ordering, lifecycle filtering, latest-revision lookup, and per-repo package listing.
6. Add a mock.maybe for a flaky unit test because of watcher go routine.

• Why it’s needed: The previous findUpstreamRefsFromDB used a PostgreSQL regex operator (~) against the full tasks text column, which forces a sequential scan on every call — no index can accelerate regex matches over arbitrary JSON text. This query runs on every package revision delete to check for downstream references, so it becomes a bottleneck as the number of package revisions grows.

• How it works:
  On write/update, extractUpstreamRefName inspects the task list: for clone tasks it reads task.Clone.Upstream.UpstreamRef.Name, for upgrade tasks it reads task.Upgrade.NewUpstream.Name. The result is stored in upstream_ref_name.

---

Related Issue(s)

• Closes/Fixes #

---

Type of Change

• Bug fix
• New feature
• Enhancement
• Refactor
• Documentation
• Tests
• Other: ________

---

Checklist

• Code follows project style guidelines
• Self-reviewed changes
• Tests added/updated
• Documentation added/updated
• All tests and gating checks pass

---

Testing Instructions (Optional)

---

Additional Notes (Optional)

• Known issues:
• Further improvements:
• Review notes:

---

AI Disclosure

• I have used AI in the creation of this PR.

If so, please describe how:
Microsoft Copilot to analyse the code.
Kiro to generate unit tests and DB backfill code.

[netlify]

✅ Deploy Preview for kpt-porch ready!

Name	Link
🔨 Latest commit	7f1b9b9
🔍 Latest deploy log	https://app.netlify.com/projects/kpt-porch/deploys/6a328f4312dc0300083dcb18
😎 Deploy Preview	https://deploy-preview-1043--kpt-porch.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR adds a persisted upstream_ref_name to package_revisions so upstream-reference lookups can use an indexed column instead of regex matching against tasks.

Changes:

• Add upstream_ref_name column and an index to support fast upstream reference lookups.
• Populate upstream_ref_name on write/update and switch findUpstreamRefsFromDB to query the new column.
• Add a startup backfill to populate upstream_ref_name for existing rows.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
pkg/cache/dbcache/dbpackagerevisionsql.go	Writes/updates the new column, replaces regex search with indexed lookup, and adds a backfill routine.
pkg/cache/dbcache/dbcachefactory.go	Runs the new upstream_ref_name backfill during cache initialization.
deployments/porch/3-porch-postgres-bundle.yaml	Updates bundled Postgres schema with the new column and index.
api/sql/porch-db.sql	Updates canonical schema with the new column and index.
api/sql/porch-db-1.6.0-1.5.9.sql	Alters downgrade migration behavior for the new column.
api/sql/porch-db-1.5.11-1.6.0.sql	Adds upgrade migration for the new column and related indexes.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 6 comments.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[kushnaidu]

done

[nagygergo]

Why does the backfill methods need to be broken down to multiple transactions?

[kushnaidu]

Why does the backfill methods need to be broken down to multiple transactions?

Copilot suggested it so that there won't be sudden spike at the start of the system pod when there are 1000s of entries which require an update.