add wasm functionality to apply-setters and rewrite to new go kpt fn sdk#915
Open
wmuizelaar wants to merge 1 commit intokptdev:mainfrom
Open
add wasm functionality to apply-setters and rewrite to new go kpt fn sdk#915wmuizelaar wants to merge 1 commit intokptdev:mainfrom
wmuizelaar wants to merge 1 commit intokptdev:mainfrom
Conversation
c0eedfe to
760d962
Compare
Contributor
|
Hi, @wmuizelaar, thank you for the contribution. We do not want to add new features to the apply-setter functions, as explained in kptdev/kpt#3131. For your use cases, I'd recommend using apply-replacements function instead as we talked about in the office hour. I understand the apply-replacement may not be sufficient enough from the feasibility and maintenance perspective. If that's the case, do you mind sharing your examples in kptdev/kpt#3131 so we can evaluate and further help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like #911 - this adds wasm functionality to
apply-setters. As discussed during the latest office-hours I also attempted to port the functionality to the new SDK.Please review thoroughly and share feedback - I tried to keep as much of the old code in place as possible, but I wasn't able to properly read the 'old' ConfigMap configuration structure, so had to craft a new config format - which is obviously a breaking change. I'm not too happy with that, so ideas on how to prevent that are appreciated ;-)