Skip to content

fix default value for compiler_temp_dir#832

Merged
kpet merged 3 commits intokpet:mainfrom
rjodinchr:ShaobinTao/main
Mar 31, 2026
Merged

fix default value for compiler_temp_dir#832
kpet merged 3 commits intokpet:mainfrom
rjodinchr:ShaobinTao/main

Conversation

@rjodinchr
Copy link
Copy Markdown
Contributor

No description provided.

@rjodinchr rjodinchr force-pushed the ShaobinTao/main branch 10 times, most recently from 2024f5b to fd5b56e Compare November 4, 2025 17:12
@rjodinchr
Copy link
Copy Markdown
Contributor Author

Require google/clspv#1543 to remove the patch for clspv

Comment thread src/config.def Outdated
@rjodinchr rjodinchr marked this pull request as ready for review December 9, 2025 07:22
Copy link
Copy Markdown
Owner

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but I think you need to update the documented default in README.md.

@rjodinchr
Copy link
Copy Markdown
Contributor Author

Looks fine but I think you need to update the documented default in README.md.

Good point, cannot wait to see #810 (which depends on #836) go through. After them, we should be in better shape to have the code and the documentation in one place.

Copy link
Copy Markdown
Owner

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kpet kpet merged commit 9bffdc2 into kpet:main Mar 31, 2026
9 checks passed
@rjodinchr rjodinchr deleted the ShaobinTao/main branch March 31, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants