Open
Conversation
Contributor
|
@kpet : can you help review this PR at your earliest convenience so that it can merged and be made available to end users? |
Some build options are needed at link time, while they are only provided at compile time. Add a new container to manage build options in order to get what we need at link time from compiled cvk_program. Update clvk_binary_header to get those information as well as program can be exported, then imported with those information. Ref kpet#822
rjodinchr
force-pushed
the
pr/binary-header
branch
from
10a998f to
f163b01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some build options are needed at link time, while they are only provided at compile time.
Add a new container to manage build options in order to get what we need at link time from compiled cvk_program.
Update clvk_binary_header to get those information as well as program can be exported, then imported with those information.
Ref #822