Open
Conversation
Contributor
|
Test this PR by running the following command: Run this branch locally: |
Owner
|
/agent the endpoint should be authenticated so that only someone with the admin api key can access it. The api key can be configured in an environment variable where the api is run |
Owner
|
/review |
Author
|
The pull request adds a new endpoint to the API to add new greetings, which are stored in memory. The changes look good overall. The code implements the described functionality and includes an authentication middleware. Here are some suggestions:
I think the pull request is acceptable with the addition of a test case for the new endpoint. |
Owner
|
/agent please add a test for the new functions |
Owner
|
/agent please dont delete the tests for the other endpoints. all endpoints should be tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new endpoint in the API to add new greetings. These can just be stored in memory, dont worry about persistence.
Completed by Agent
Fixes #134