Custom Elements: CustomElementRegistry#299
Open
prasannavl wants to merge 1 commit intokoute:masterfrom
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WIP] Initial impl of
CustomElementRegistryI do have a few questions before completing this:
no_return, but then added the error type, and as such theResult<(), Err>. Does this fit the project conventions? (51e683c#diff-55e0c9ca42d6126fc52bcae5a9a2bf95R41)Optionbe returned. Does this fit the project conventions, or should this be a result with empty error/not found error? What's the best way to representundefinedhere. (51e683c#diff-55e0c9ca42d6126fc52bcae5a9a2bf95R48)