Skip to content

Custom Elements: CustomElementRegistry#299

Open
prasannavl wants to merge 1 commit intokoute:masterfrom
prasannavl:patch-1
Open

Custom Elements: CustomElementRegistry#299
prasannavl wants to merge 1 commit intokoute:masterfrom
prasannavl:patch-1

Conversation

@prasannavl
Copy link
Copy Markdown

@prasannavl prasannavl commented Nov 7, 2018

[WIP] Initial impl of CustomElementRegistry

I do have a few questions before completing this:

  1. How exactly do I represent a Constructor here? (51e683c#diff-55e0c9ca42d6126fc52bcae5a9a2bf95R38)
  2. Is it okay to unwrap, this? Initially I did a no_return, but then added the error type, and as such the Result<(), Err>. Does this fit the project conventions? (51e683c#diff-55e0c9ca42d6126fc52bcae5a9a2bf95R41)
  3. Again, constructor type. But also, can Option be returned. Does this fit the project conventions, or should this be a result with empty error/not found error? What's the best way to represent undefined here. (51e683c#diff-55e0c9ca42d6126fc52bcae5a9a2bf95R48)
  4. I followed this convention by looking at other implementations, but it is correct to unwrap this? (51e683c#diff-55e0c9ca42d6126fc52bcae5a9a2bf95R59)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants