In webbrowser load WASM from same folder as JS#222
Open
bertdemiranda wants to merge 1 commit intokoute:masterfrom
Open
In webbrowser load WASM from same folder as JS#222bertdemiranda wants to merge 1 commit intokoute:masterfrom
bertdemiranda wants to merge 1 commit intokoute:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #131 "Question: how to specify the wasm path in the generated js file?".
In the current version it is assumed (when running inside a webbrowser)
that the WASM module is located in the default path,
which is not always the case (in my case I have a webserver serving
a number of different WASM modules in different paths).
This modification to src/wasm_runtime_standalone.js will do for
the webbrowser case the same as it already does for the NodeJS case:
to get the URL for the javascript file that is then itself running,
and then load the WASM module from the same directory.
The logic for getting the URL for the Javascript file I have
taken from this thread: https://stackoverflow.com/questions/3097644/can-code-in-a-javascript-file-know-its-own-domain-url .
Maybe there is now a better way to do this?