Update closeKeyboardWhenScrolling documentation#163
Open
julien-levarlet wants to merge 1 commit intokoukibadr:mainfrom
Open
Update closeKeyboardWhenScrolling documentation#163julien-levarlet wants to merge 1 commit intokoukibadr:mainfrom
julien-levarlet wants to merge 1 commit intokoukibadr:mainfrom
Conversation
Owner
|
@julien-levarlet good catch thank you, but looking back at this maybe it's better if the check on the focus node is removed to ease the usage of the flag |
Contributor
Author
|
Yes, simplifying its use can be great. |
Owner
|
Yes that make sense since the flag is called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was working with the
closeKeyboardWhenScrollingattribute and I noticed that the documentation doesn't mention that the focusNode has to be set to make it work. It updated the doc string to make it clearer.In the code below, if no focusNode is set, the condition will always be false