Skip to content

Allow readonly array in where#109

Open
ftzi wants to merge 1 commit into
kossnocorp:v8from
ftzi:allow-readonly-array-in-where
Open

Allow readonly array in where#109
ftzi wants to merge 1 commit into
kossnocorp:v8from
ftzi:allow-readonly-array-in-where

Conversation

@ftzi
Copy link
Copy Markdown

@ftzi ftzi commented Jan 7, 2022

Allows

const array = ['a', 'b'] as const;
query(doc, [where('key', 'in', array)])

Without this PR, an error is throw:

No overload matches this call.
  The last overload gave the following error.
    Argument of type 'string' is not assignable to parameter of type '[keyof DbOrder, string | number | symbol, string | number | symbol, string | number | symbol, string | number | symbol, string | number | symbol, string | number | symbol, string | ... 1 more ... | symbol, string | ... 1 more ... | symbol, string | ... 1 more ... | symbol]'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant