docs(site): Add guideline for localization#3776
Draft
lupusA wants to merge 3 commits intokopia:masterfrom
Draft
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3776 +/- ##
==========================================
+ Coverage 75.86% 76.96% +1.09%
==========================================
Files 470 476 +6
Lines 37301 29039 -8262
==========================================
- Hits 28299 22349 -5950
+ Misses 7071 4749 -2322
- Partials 1931 1941 +10 ☔ View full report in Codecov by Sentry. |
added 2 commits
April 7, 2024 20:56
julio-lopez
reviewed
Apr 19, 2024
| @@ -10,13 +10,15 @@ weight: 50 | |||
| ## Localisation Guidlines | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| ## Localisation Guidlines | |
| ## Localisation Guidelines |
| TBD | ||
|
|
||
| ### Tests | ||
| ```kopiaUI``` features different tests to prevent situations where translations become obsolet and or unused. The tests check for keys with empty or null values and that keys exist in all provided translation files. The tests will fail if translation files contain empty keys or if keys are not declared in all files. Additionally, the test extracts the currently used translation keys within the code to check if all keys are used at least once. |
Collaborator
There was a problem hiding this comment.
Suggested change
| ```kopiaUI``` features different tests to prevent situations where translations become obsolet and or unused. The tests check for keys with empty or null values and that keys exist in all provided translation files. The tests will fail if translation files contain empty keys or if keys are not declared in all files. Additionally, the test extracts the currently used translation keys within the code to check if all keys are used at least once. | |
| ```kopiaUI``` features different tests to prevent situations where translations become obsolete and or unused. The tests check for keys with empty or null values and that keys exist in all provided translation files. The tests will fail if translation files contain empty keys or if keys are not declared in all files. Additionally, the test extracts the currently used translation keys within the code to check if all keys are used at least once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this PR adds the ability to support localisation in kopia-UI. The PR contains the following changes:
This PR has a dependency to kopia/htmlui#241
Feedback is welcomed.