Add upload and download limits to GUI #412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parseBytes() and formatBytes() utility functions to support human-readable byte notation using K, M, G suffixes (e.g., "1.5M", "100K", "1G").
Add UI for configuring repository throttle settings with: - Maximum upload/download speed controls - Human-readable format using K, M, G notation - Auto-fetch on repository connection - Only shown for direct repository connections (not API server)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now set upload and download limits on the repository page.
As these are the first inputs that are actually enabled on that page, I created a new section to set them apart.
I am open to moving them around or implementing them differently.
(Maybe there should be a hint that tells the user, that these limits probably don't do what the user thinks. I was suprised that Kopia uses token throttling instead of throttling "live" like rsync does.)
This should close #5063 and #3586.