MoleClient: allow sending Object as params#15
Open
yoursunny wants to merge 1 commit intokoorchik:masterfrom
Open
MoleClient: allow sending Object as params#15yoursunny wants to merge 1 commit intokoorchik:masterfrom
yoursunny wants to merge 1 commit intokoorchik:masterfrom
Conversation
Author
|
Hey @koorchik can you review and merge? |
Author
|
After a long time without action from the repository owner, I have decided to publish my patches in a fork: @yoursunny/mole-rpc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON-RPC 2.0 specification allows
paramsto be either an Array or an Object. However, currentMoleClientimplementation can only accept array; it would reject objects unless it has an.lengthproperty.This patch allows
MoleClientto accept an Object asparams.This is useful for interacting with RPC servers written in Go language, because the official Go guides for
net/rpcpackage default to using objects.This feature has been tested with the following snippet:
client.js
server.go