-
Notifications
You must be signed in to change notification settings - Fork 54
Савицких Антон, 2ДЗ #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Xineev
wants to merge
2
commits into
kontur-courses:master
Choose a base branch
from
Xineev:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics; | ||
| using System.Linq; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Text; | ||
| using System.Threading.Tasks; | ||
| using log4net; | ||
|
|
@@ -13,9 +15,86 @@ public SmartClusterClient(string[] replicaAddresses) : base(replicaAddresses) | |
| { | ||
| } | ||
|
|
||
| public override Task<string> ProcessRequestAsync(string query, TimeSpan timeout) | ||
| public override async Task<string> ProcessRequestAsync(string query, TimeSpan timeout) | ||
| { | ||
| throw new NotImplementedException(); | ||
| var stopwatch = Stopwatch.StartNew(); | ||
| var tasks = new Dictionary<Task<string>, string>(); | ||
| var replicasToCall = ReplicaAddresses.Length; | ||
|
|
||
| var ordered = SortedReplicas.ToList(); | ||
| var timeoutPerReplica = timeout.Divide(ordered.Count); | ||
| var replicasLeft = ordered.Count; | ||
|
|
||
| foreach (var replica in ordered) | ||
| { | ||
| if (stopwatch.Elapsed >= timeout) | ||
| break; | ||
|
|
||
| var webRequest = CreateRequest(replica + "?query=" + query); | ||
| Log.InfoFormat($"Processing {webRequest.RequestUri}"); | ||
|
|
||
| var requestTask = ProcessRequestAsync(webRequest); | ||
| tasks[requestTask] = replica; | ||
|
|
||
|
|
||
| var weight = ReplicaAddresses.Length - replicasToCall + 1; | ||
| var targetTimeForNextStart = timeoutPerReplica * weight; | ||
|
|
||
| var waitTime = targetTimeForNextStart - stopwatch.Elapsed; | ||
| var waitTask = Task.Delay(waitTime); | ||
|
|
||
| replicasToCall--; | ||
|
|
||
| if (waitTime > TimeSpan.Zero) | ||
| { | ||
| var completedTask = await Task.WhenAny(tasks.Keys.Concat(new[] { waitTask })); | ||
|
|
||
| if(completedTask == waitTask) | ||
| continue; | ||
|
|
||
| var addr = tasks[(Task<string>)completedTask]; | ||
| tasks.Remove((Task<string>)completedTask); | ||
|
|
||
| try | ||
| { | ||
| RecordResponse(addr, stopwatch.ElapsedMilliseconds, true); | ||
| return await (Task<string>)completedTask; | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| RecordResponse(addr, 0, false); | ||
| Log.ErrorFormat($"Replica request failed: {ex.Message}"); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| while (tasks.Count > 0 && stopwatch.Elapsed < timeout) | ||
| { | ||
| var remainingTime = timeout - stopwatch.Elapsed; | ||
| var waitTask = Task.Delay(remainingTime); | ||
|
|
||
| var completedTask = await Task.WhenAny(tasks.Keys.Concat(new[] { waitTask })); | ||
|
|
||
| if (completedTask == waitTask) | ||
| break; | ||
|
Comment on lines
78
to
79
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. В этом случае не вызовется RecordResponse для затормозивших реплик |
||
|
|
||
| var addr = tasks[(Task<string>)completedTask]; | ||
| tasks.Remove((Task<string>)completedTask); | ||
|
|
||
|
|
||
| try | ||
| { | ||
| RecordResponse(addr, stopwatch.ElapsedMilliseconds, true); | ||
| return await (Task<string>)completedTask; | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| RecordResponse(addr, 0, false); | ||
| Log.ErrorFormat($"Replica request failed: {ex.Message}"); | ||
| } | ||
| } | ||
|
|
||
| throw new TimeoutException("All replicas failed"); | ||
| } | ||
|
|
||
| protected override ILog Log => LogManager.GetLogger(typeof(SmartClusterClient)); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
По-хорошему timeoutTask бы создать до вызовов
ProcessRequestAsync. Иначе выходит, что запросы уже какое-то время как отправлены