Fixes #437 : Updated GetAvailableDiskSize function#438
Open
sundaram2021 wants to merge 2 commits intokonstructio:mainfrom
Open
Fixes #437 : Updated GetAvailableDiskSize function#438sundaram2021 wants to merge 2 commits intokonstructio:mainfrom
sundaram2021 wants to merge 2 commits intokonstructio:mainfrom
Conversation
Contributor
|
Hey @sundaram2021! Would you mind bumping/updating the We would love to merge this whenever possible! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
in internal/validations.go
we have syscall.Statfs and Statfs_t which are os specific methods and does not work in windows
so what i have does add a pkf "github.com/shirou/gopsutil/disk"
which is used to calculate the available disk and it is os independent and maintained regularly
Related Issue(s)
Fixes # 437
How to test
clone repo on a windows machine and you will straight away see that