Fix delete_command not removing buttons#18
Merged
Conversation
Broadlink uses async_delay_save with a 15-second write delay, but DELETE_SCAN_DELAY was only 2 seconds. The re-scan read stale data from disk before the write completed. Increase to 30 seconds to match LEARN_SCAN_DELAY. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async_delay_savewithCODE_SAVE_DELAY = 15seconds when persisting command deletions to disk. OurDELETE_SCAN_DELAYwas only 2 seconds, so the re-scan read stale storage data before the write completed — the deleted command still appeared in storage, so no button was removed.DELETE_SCAN_DELAYfrom 2 to 30 seconds (matchingLEARN_SCAN_DELAY), ensuring the scan runs well after the storage write completes.Test plan
remote.delete_command, verify button is removed after ~30 seconds🤖 Generated with Claude Code