Expose version to jreleaser directive#944
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary of ChangesHello @komamitsu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the build.gradle.kts file to move the group and version properties from the subprojects configuration block to the root project scope. This change correctly exposes these properties to plugins applied at the root level, such as jreleaser, which aligns with the pull request's goal. It's a good improvement that centralizes common project properties, following standard Gradle practices for multi-project builds. The code change is correct and improves the build script's structure and maintainability. No issues were found.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the Gradle build to centralize version management and correctly configure jreleaser for a multi-project build. The changes are a good improvement, fixing a bug in version file pathing and adopting standard practices for multi-project builds. However, the PR also removes the idea, jacoco, and coveralls plugins and their configurations. This removes IDE support generation and code coverage reporting, which seems unrelated to the PR's stated goal and might be unintentional. My review includes comments highlighting these potentially unintended removals.
I am having trouble creating individual review comments. Click here to see my feedback.
build.gradle.kts (147-180)
This change removes the entire code coverage configuration, including the jacoco and coveralls plugins and their associated tasks (the plugin declarations are also removed elsewhere in this file). While the main goal of the PR is to refactor the jreleaser configuration, removing code coverage reporting is a significant change that might be unintentional, especially as it's not mentioned in the PR description. If code coverage reporting is still required, this configuration should be restored and adapted to the new build structure.
build.gradle.kts (12)
The idea plugin, which generates IntelliJ IDEA project files, has been removed. This might negatively impact developers who rely on it for their IDE setup. If this removal was not intentional, the plugin should be restored.
No description provided.