Skip to content

Expose version to jreleaser directive#944

Merged
komamitsu merged 4 commits intomasterfrom
fix-release-version
Jan 4, 2026
Merged

Expose version to jreleaser directive#944
komamitsu merged 4 commits intomasterfrom
fix-release-version

Conversation

@komamitsu
Copy link
Copy Markdown
Owner

No description provided.

@komamitsu komamitsu requested a review from Copilot January 4, 2026 10:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @komamitsu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the build.gradle.kts file to establish a more global and accessible definition of the project's group and version. By applying the version.gradle script and setting the group at the root project level, the project's version information becomes readily available to top-level plugins, specifically facilitating its use by the jreleaser plugin for release management.

Highlights

  • Global Configuration for Group and Version: The project's group property and the application of the version.gradle script have been moved from the subprojects block to the root of the build.gradle.kts file. This change centralizes these configurations, making them apply to the root project and its subprojects more consistently.
  • Enhanced jreleaser Integration: By elevating the version.gradle script application to the root project, the version property is now directly accessible to the jreleaser plugin. This ensures that jreleaser can correctly pick up and utilize the project's defined version for release processes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the build.gradle.kts file to move the group and version properties from the subprojects configuration block to the root project scope. This change correctly exposes these properties to plugins applied at the root level, such as jreleaser, which aligns with the pull request's goal. It's a good improvement that centralizes common project properties, following standard Gradle practices for multi-project builds. The code change is correct and improves the build script's structure and maintainability. No issues were found.

@komamitsu komamitsu requested a review from Copilot January 4, 2026 12:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@komamitsu
Copy link
Copy Markdown
Owner Author

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Gradle build to centralize version management and correctly configure jreleaser for a multi-project build. The changes are a good improvement, fixing a bug in version file pathing and adopting standard practices for multi-project builds. However, the PR also removes the idea, jacoco, and coveralls plugins and their configurations. This removes IDE support generation and code coverage reporting, which seems unrelated to the PR's stated goal and might be unintentional. My review includes comments highlighting these potentially unintended removals.

I am having trouble creating individual review comments. Click here to see my feedback.

build.gradle.kts (147-180)

high

This change removes the entire code coverage configuration, including the jacoco and coveralls plugins and their associated tasks (the plugin declarations are also removed elsewhere in this file). While the main goal of the PR is to refactor the jreleaser configuration, removing code coverage reporting is a significant change that might be unintentional, especially as it's not mentioned in the PR description. If code coverage reporting is still required, this configuration should be restored and adapted to the new build structure.

build.gradle.kts (12)

medium

The idea plugin, which generates IntelliJ IDEA project files, has been removed. This might negatively impact developers who rely on it for their IDE setup. If this removal was not intentional, the plugin should be restored.

@komamitsu komamitsu merged commit a239dd8 into master Jan 4, 2026
12 checks passed
@komamitsu komamitsu deleted the fix-release-version branch January 4, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants