Skip to content

各種テストなどの修正#640

Open
4ster1sk wants to merge 22 commits intokokonect-link:developfrom
4ster1sk:fix/tests
Open

各種テストなどの修正#640
4ster1sk wants to merge 22 commits intokokonect-link:developfrom
4ster1sk:fix/tests

Conversation

@4ster1sk
Copy link
Copy Markdown
Contributor

@4ster1sk 4ster1sk commented Mar 24, 2026

What

GitHub Actions によるテストがすべて通過するよう修正しました。
あわせて、npm の依存関係を更新しています。

ただし、以下の問題・懸念点が残っています。

  1. FK_poll_vote_pollを削除したことにより、副作用が発生する可能性があります。
  2. 配送先制限アイコン内でインスタンス名が表示されなくなります。
  3. 一部のMkFollowButtonが表示されなくなります。
  4. DeleteAccountProcessorService内でremoteUserUpdatedイベントが発火しなくなります。
  5. npmの依存関係更新により、予期しない挙動が発生する可能性があります。
  6. 新規インスタンスの立ち上げは出来ることを確認していますが、実運用環境でのバージョンアップ動作確認は行っていません。

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 74.50980% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.18%. Comparing base (e784148) to head (585e00e).

Files with missing lines Patch % Lines
...ages/frontend/src/components/global/RouterView.vue 0.00% 10 Missing and 5 partials ⚠️
packages/frontend/src/components/MkPostForm.vue 0.00% 2 Missing and 4 partials ⚠️
...ue/processors/PostScheduledNoteProcessorService.ts 0.00% 3 Missing ⚠️
packages/frontend/src/os.ts 0.00% 2 Missing and 1 partial ⚠️
...ges/backend/src/core/entities/NoteEntityService.ts 0.00% 2 Missing ⚠️
packages/frontend/src/aiscript/api.ts 0.00% 2 Missing ⚠️
packages/frontend/src/components/MkNote.vue 0.00% 2 Missing ⚠️
...ackages/backend/src/queue/QueueProcessorService.ts 0.00% 1 Missing ⚠️
.../queue/processors/DeleteAccountProcessorService.ts 0.00% 1 Missing ⚠️
...ackages/backend/src/server/api/SignupApiService.ts 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #640       +/-   ##
============================================
+ Coverage    12.40%   61.18%   +48.77%     
============================================
  Files          256     1232      +976     
  Lines        13637   128525   +114888     
  Branches      4704     9163     +4459     
============================================
+ Hits          1692    78638    +76946     
- Misses        9278    47175    +37897     
- Partials      2667     2712       +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -472,6 +472,11 @@
                   "items": {
                     "type": "object",
                     "properties": {
+                      "id": {
+                        "type": "string",
+                        "format": "id",
+                        "example": "xxxxxxxxxx"
+                      },
                       "name": {
                         "type": "string"
                       },
@@ -501,6 +506,7 @@
                       }
                     },
                     "required": [
+                      "id",
                       "name",
                       "targetUserPattern",
                       "reporterPattern",
@@ -78964,7 +78970,10 @@
                     "format": "misskey:id"
                   },
                   "text": {
-                    "type": "string",
+                    "type": [
+                      "string",
+                      "null"
+                    ],
                     "minLength": 1,
                     "maxLength": 3000
                   },
@@ -95980,6 +95989,12 @@
           },
           "withReplies": {
             "type": "boolean"
+          },
+          "approved": {
+            "type": "boolean"
+          },
+          "signupReason": {
+            "type": "string"
           }
         },
         "required": [
@@ -97615,6 +97630,41 @@
             "type": [
               "object",
               "null"
+            ],
+            "properties": {
+              "title": {
+                "type": "string"
+              },
+              "start": {
+                "type": "string",
+                "format": "date-time"
+              },
+              "end": {
+                "type": [
+                  "string",
+                  "null"
+                ],
+                "format": "date-time"
+              },
+              "metadata": {
+                "type": "object",
+                "properties": {
+                  "@type": {
+                    "type": "string"
+                  },
+                  "location": {
+                    "type": "string"
+                  },
+                  "description": {
+                    "type": "string"
+                  }
+                }
+              }
+            },
+            "required": [
+              "title",
+              "start",
+              "end"
             ]
           },
           "channelId": {
@@ -98880,6 +98930,47 @@
               "type": {
                 "type": "string",
                 "enum": [
+                  "note:grouped"
+                ]
+              },
+              "noteIds": {
+                "type": "array",
+                "items": {
+                  "type": [
+                    "string",
+                    "null"
+                  ]
+                }
+              },
+              "users": {
+                "type": "array",
+                "items": {
+                  "$ref": "#/components/schemas/UserLite"
+                }
+              }
+            },
+            "required": [
+              "id",
+              "createdAt",
+              "type",
+              "noteIds",
+              "users"
+            ]
+          },
+          {
+            "type": "object",
+            "properties": {
+              "id": {
+                "type": "string",
+                "format": "id"
+              },
+              "createdAt": {
+                "type": "string",
+                "format": "date-time"
+              },
+              "type": {
+                "type": "string",
+                "enum": [
                   "test"
                 ]
               }
@@ -102552,14 +102643,24 @@
                 "format": "date-time"
               },
               "metadata": {
-                "type": "object"
+                "type": "object",
+                "properties": {
+                  "@type": {
+                    "type": "string"
+                  },
+                  "location": {
+                    "type": "string"
+                  },
+                  "description": {
+                    "type": "string"
+                  }
+                }
               }
             },
             "required": [
               "title",
               "start",
-              "end",
-              "metadata"
+              "end"
             ]
           },
           "fileIds": {
[Get diff files from Workflow Page](https://github.com/kokonect-link/cherrypick/actions/runs/23488350754)

@github-actions
Copy link
Copy Markdown
Contributor

Backend Memory Usage Comparison

Metric base head Diff
RSS 390.32 MB 398.82 MB 8.50 MB (2.17%)

See workflow logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants