feat: Set {field}_URL to Deleted for attachments marked as deleted
#335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajpatel24
changed the title
is_deleted field and set url to Deleted for deleted attachments{field}_is_deleted column and set {field}_URL to Deleted for deleted attachments
9 tasks
noliveleger
requested changes
Jun 5, 2025
src/formpack/schema/fields.py
Outdated
| class MediaField(TextField): | ||
| def get_labels(self, include_media_url=False, *args, **kwargs): | ||
| label = self._get_label(*args, **kwargs) | ||
| labels = [label, f'{label}_is_deleted'] |
Contributor
There was a problem hiding this comment.
Actually, requirements say:
Set URL cell to ‘Deleted’ - Only if “Include media URLS” is checked
So no need to add another field. Just replace the attachment URL with "Deleted"
src/formpack/schema/fields.py
Outdated
| ): | ||
| if val is None: | ||
| val = '' | ||
| first_attachment = attachment[0] if attachment else {} |
Contributor
There was a problem hiding this comment.
first_attachment is misleading IMO. I was thinking about other attachments in the same list.
What about using attachment again? attachment = attachment[0] ...
Contributor
Author
There was a problem hiding this comment.
You're right! I've updated it accordingly
rajpatel24
force-pushed
the
handle-deleted-attachments
branch
from
0bca3fa to
7f6e8e4
Compare
rajpatel24
changed the title
{field}_is_deleted column and set {field}_URL to Deleted for deleted attachments{field}_URL to Deleted for attachments marked as deleted
rajpatel24
added a commit
to kobotoolbox/kpi
that referenced
this pull request
Jun 9, 2025
…ts TASK-575 (#5819) ### 📣 Summary Ensure KPI installs the latest formpack version to support new export features for deleted media attachments. ### 📖 Description This PR updates the formpack dependency hash in `requirements.in`, `requirements.txt`, and `dev_requirements.txt` to use the commit from [formpack#335](kobotoolbox/formpack#335). That PR introduces support for displaying deleted attachments more clearly in exports: - Replaces `{field}_URL` with the text `Deleted` when the attachment is marked as deleted and `include_media_url=True`. These changes ensure that exports generated by KPI reflect deleted attachments more transparently for end users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set
{field}_URLto 'Deleted' for deleted attachments, wheninclude_media_urlis True.Description
{field}_URLto 'Deleted' if the attachment is marked as deleted andinclude_media_urlis True.{field}_URLfield.