fix(combobox): destructive fix #514 - do not freeze popover content nor display old options #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kobalte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
Idea for non destructive fixCan add a prop to disable this behaviour. Though this solution seems jank. |
MengLinMaker
changed the title
MengLinMaker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destructive fix
closes #514
This removes the ability to freeze content as
optionsupdate when popover is closed.Freezing content and displaying old options seem like a weird behaviour. Unless I'm missing something.
Note: combobox test is skipped. Unskipping leads to failed tests since popover fails to open - see issue #254