Skip to content

feat(feeds): deepen Polish (pl) news sources — PAP wire, Gazeta Wyborcza, OKO.press#3895

Open
zionappp-ui wants to merge 2 commits into
koala73:mainfrom
zionappp-ui:feat/pl-sources
Open

feat(feeds): deepen Polish (pl) news sources — PAP wire, Gazeta Wyborcza, OKO.press#3895
zionappp-ui wants to merge 2 commits into
koala73:mainfrom
zionappp-ui:feat/pl-sources

Conversation

@zionappp-ui
Copy link
Copy Markdown
Contributor

What this adds

Deepens the Polish (`pl`) locale with 6 new sources and fixes server/client parity for the 3 existing feeds (TVN24, Polsat News, Rzeczpospolita were in `src/config/feeds.ts` but missing from `server/worldmonitor/news/v1/_feeds.ts`).

New sources (6 feeds, all verified live)

Source Type RSS Items Tier
PAP (national wire) wire direct 50 1
Gazeta Wyborcza mainstream Google News pl 50 1
Polityka mainstream Google News pl 50 2
Onet mainstream direct 50 2
OKO.press (fact-checking) intel Google News pl 91 2
TVP Info (public broadcaster) mainstream Google News pl 100 2

Server parity fix

TVN24, Polsat News, Rzeczpospolita were in the client config but absent from the server digest — added to both.

PAP is Poland's national wire agency. OKO.press is Poland's leading fact-checking and investigative outlet.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 24, 2026

@zionappp-ui is attempting to deploy a commit to the World Monitor Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the trust:caution Brin: contributor trust score caution label May 24, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 24, 2026

Greptile Summary

This PR deepens the Polish (pl) locale by adding 6 new news sources (PAP, Gazeta Wyborcza, Polityka, Onet, OKO.press, TVP Info) and fixes server/client parity for 3 existing feeds (TVN24, Polsat News, Rzeczpospolita) that were previously absent from the server digest.

  • New direct-RSS domains (www.pap.pl, wiadomosci.onet.pl) are correctly added to all three allowlist locations (api/_rss-allowed-domains.js, shared/rss-allowed-domains.json, vite.config.ts); Google News-proxied feeds need no allowlist entry.
  • All 6 new sources are registered in SOURCE_TYPES and source-tiers.json; however the 3 parity-fixed feeds (TVN24, Polsat News, Rzeczpospolita) were not added to SOURCE_TYPES and continue to resolve as 'other' in the analysis worker.
  • Both source-tiers.json files contain an unintended side-effect: three pre-existing accented-character keys (El País, Híradó, La Silla Vacía) were silently converted to Unicode escape sequences during editing.

Confidence Score: 4/5

Safe to merge; the core feed additions and allowlist updates are correct and consistent across all config locations.

The new sources are wired correctly end-to-end: direct-RSS domains added to all three allowlist files, Google News feeds need no allowlist entry, server and client feed arrays both updated. The two minor gaps — three parity-fixed feeds still missing from SOURCE_TYPES, and an editor-induced Unicode escape conversion on unrelated accented entries — are non-blocking but leave the codebase slightly less consistent than before.

shared/source-tiers.json and scripts/shared/source-tiers.json for the Unicode escape side-effect; src/config/feeds.ts for the missing SOURCE_TYPES entries on TVN24, Polsat News, and Rzeczpospolita.

Important Files Changed

Filename Overview
src/config/feeds.ts Adds 6 new Polish sources to SOURCE_TYPES and FULL_FEEDS; three existing parity-fixed feeds (TVN24, Polsat News, Rzeczpospolita) remain unregistered in SOURCE_TYPES.
server/worldmonitor/news/v1/_feeds.ts Adds 9 Polish server feeds (3 parity + 6 new) correctly into the europe block, using gnLocale() for Google News feeds and direct URLs for PAP/Onet.
shared/source-tiers.json Appends 6 new Polish tier entries; introduces unintentional Unicode escape conversion of 3 existing accented-character keys (El País, Híradó, La Silla Vacía) — also replicated in scripts/shared/source-tiers.json.
api/_rss-allowed-domains.js Adds www.pap.pl and wiadomosci.onet.pl to the allowlist, matching the two new direct-RSS domains. Google-News-proxied feeds correctly do not need entries here.
vite.config.ts Adds the same two direct-RSS domains to the Vite RSS_PROXY_ALLOWED_DOMAINS set, keeping dev-server allowlist in sync with the API allowlist.
scripts/shared/source-tiers.json Mirror of shared/source-tiers.json; same Unicode escape side-effect on existing entries, same new Polish tier additions.
scripts/shared/rss-allowed-domains.json Mirror of shared/rss-allowed-domains.json; www.pap.pl and wiadomosci.onet.pl added correctly.
shared/rss-allowed-domains.json Adds two new direct-RSS domains alongside existing Polish domains already present (tvn24.pl, www.polsatnews.pl, www.rp.pl).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Client: src/config/feeds.ts\nFULL_FEEDS europe block] -->|rss proxy URL| B[RSS Proxy\napi/_rss-allowed-domains.js\nvite.config.ts]
    A -->|source name| C[SOURCE_TYPES\ngetSourceType]
    A -->|source name| D[source-tiers.json\ngetSourceTier]

    E[Server: _feeds.ts\nVARIANT_FEEDS.full.europe] -->|direct or gnLocale URL| F[Server-side fetch\nno proxy needed]

    B -->|www.pap.pl ✅| G[PAP direct RSS]
    B -->|wiadomosci.onet.pl ✅| H[Onet direct RSS]
    B -->|news.google.com ✅ existing| I[Wyborcza / Polityka /\nOKO.press / TVP Info\nvia Google News]

    C -->|PAP → wire ✅| J[Analysis Worker]
    C -->|OKO.press → intel ✅| J
    C -->|TVN24 → other ⚠️ missing| J
    C -->|Polsat News → other ⚠️ missing| J
    C -->|Rzeczpospolita → other ⚠️ missing| J

    D -->|PAP tier 1 ✅| K[Source Tier Scoring]
    D -->|Gazeta Wyborcza tier 1 ✅| K
Loading

Reviews (1): Last reviewed commit: "feat(feeds): deepen Polish (pl) sources ..." | Re-trigger Greptile

Comment thread shared/source-tiers.json Outdated
"Yonhap News": 2,
"Chosun Ilbo": 2,
"El País": 2,
"El Pa\u00eds": 2,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unintentional Unicode escape conversion on existing entries

Three pre-existing entries with accented characters — El País, Híradó, and La Silla Vacía — were rewritten from their native UTF-8 form to JSON Unicode escapes (\u00ed, \u00f3, \u00ed). The same change appears in scripts/shared/source-tiers.json. Both representations parse identically, but the diff noise suggests this was a side-effect of the editor or tool used to append the new entries. If any code does string-literal comparison against the raw JSON bytes rather than the parsed value, this would silently break those checks.

Comment thread src/config/feeds.ts
Comment on lines +55 to +56
// Polish (PL) additions
'PAP': 'wire', 'Gazeta Wyborcza': 'mainstream', 'Polityka': 'mainstream', 'Onet': 'mainstream', 'OKO.press': 'intel', 'TVP Info': 'mainstream',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Pre-existing TVN24, Polsat News, Rzeczpospolita still absent from SOURCE_TYPES

The server-parity fix adds these three feeds to _feeds.ts, but they remain missing from SOURCE_TYPES in this file. getSourceType() falls back to 'other' for any key not found in the map (line 103), so the analysis worker classifies all three as 'other' rather than 'mainstream'. Since this PR explicitly touches the Polish source set and SOURCE_TYPES, it's a natural place to close this gap alongside the six new entries.

@koala73 koala73 added the area: i18n Internationalization, translations label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: i18n Internationalization, translations trust:caution Brin: contributor trust score caution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants