Skip to content

test: cover protx listdiff platform port restart regression #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thepastaclaw wants to merge 1 commit into
base: fix-v24-extdiff
Choose a base branch
from
Open

test: cover protx listdiff platform port restart regression #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test/functional/rpc_netinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,26 @@ def empty_common(grt_dict):
assert_equal(grt_proregtx['platformP2PPort'], DEFAULT_PORT_PLATFORM_P2P)
assert_equal(grt_proregtx['platformHTTPPort'], DEFAULT_PORT_PLATFORM_HTTP)

self.log.info("Test legacy-to-extended listdiff after restart reports valid deprecated Platform ports")
proupservtx_hash = self.node_two.update_mn(self, True,
f"127.0.0.1:{self.node_two.mn.nodePort}",
DEFAULT_PORT_PLATFORM_P2P + 1,
DEFAULT_PORT_PLATFORM_HTTP + 1)
proupservtx_height = self.node_simple.getrawtransaction(proupservtx_hash, True)['height']

# Restart the deprecated-RPC node to force deterministic MN state through the serialized
# snapshot/diff path. This caught a regression where ExtAddr Platform addresses were correct
# but the deprecated scalar ports in protx listdiff were reported as 0.
self.restart_node(self.node_simple.index)
self.reconnect_nodes()

protx_listdiff_rpc = self.node_simple.protx('listdiff', proupservtx_height - 1, proupservtx_height)
protx_listdiff_rpc = self.extract_from_listdiff(protx_listdiff_rpc, self.node_two.mn.proTxHash)
self.check_netinfo_fields(protx_listdiff_rpc['addresses'], self.node_two.mn.nodePort,
DEFAULT_PORT_PLATFORM_HTTP + 1, DEFAULT_PORT_PLATFORM_P2P + 1)
assert_equal(protx_listdiff_rpc['platformP2PPort'], DEFAULT_PORT_PLATFORM_P2P + 1)
assert_equal(protx_listdiff_rpc['platformHTTPPort'], DEFAULT_PORT_PLATFORM_HTTP + 1)

# Destroy and re-register node as blank
self.node_two.destroy_mn(self)
self.reconnect_nodes()
Expand Down