Skip to content

Fix schema reference#29

Open
blaggacao wants to merge 8 commits intoknowark:masterfrom
xoe-labs:fix-schema-reference
Open

Fix schema reference#29
blaggacao wants to merge 8 commits intoknowark:masterfrom
xoe-labs:fix-schema-reference

Conversation

@blaggacao
Copy link
Copy Markdown
Contributor

Fixing relative schema references

http://www.dian.gov.co/micrositios/fac_electronica/documentos/common

seems not to exist anymore.

David Arnold added 8 commits December 14, 2018 15:00
As a side-effect, get rid of (deprecated) pyOpenSSL dependency.

Rather provide the library with a standard pem certificate.
Maybe support DER binary format one day?
The shcema location referring to a remote site is not valid anymore
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 17, 2018

Codecov Report

Merging #29 into master will decrease coverage by 0.2%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage     100%   99.79%   -0.21%     
==========================================
  Files          94       94              
  Lines        1954     1978      +24     
  Branches       96       99       +3     
==========================================
+ Hits         1954     1974      +20     
- Misses          0        2       +2     
- Partials        0        2       +2
Impacted Files Coverage Δ
facturark/signer/encrypter.py 100% <100%> (ø) ⬆️
facturark/api.py 100% <100%> (ø) ⬆️
facturark/__main__.py 100% <100%> (ø) ⬆️
facturark/signer/resolver.py 100% <100%> (ø) ⬆️
facturark/signer/signer.py 97.64% <90%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50cbf98...5260394. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant