fix: translation directory detection to require 'translations' parent dir

src/lib/marshal/translation/helpers.ts

@@ -56,11 +56,13 @@ export const isValidLocale = (localeCode: string): boolean =>
 
 /*
  * Evaluates whether the given directory path is a translations directory
- * by checking if the directory name is a valid locale name
+ * by checking that the directory name is a valid locale name AND
+ * the parent directory is named "translations".
  */
 export const isTranslationDir = (dirPath: string): boolean => {
   const locale = path.basename(dirPath);
-  return isValidLocale(locale);
+  const parentDirName = path.basename(path.dirname(dirPath));
+  return parentDirName === "translations" && isValidLocale(locale);
 };
 
 /*

src/lib/marshal/translation/reader.ts

@@ -7,7 +7,7 @@ import { formatErrors, SourceError } from "@/lib/helpers/error";
 import { readJson } from "@/lib/helpers/json";
 
 import {
-  isTranslationDir,
+  isValidLocale,
   lsTranslationDir,
   parseTranslationRef,
   SYSTEM_NAMESPACE,
@@ -158,9 +158,7 @@ export const readAllForCommandTarget = async (
       });
 
       const translationDirPaths = dirents
-        .filter(
-          (dirent) => dirent.isDirectory() && isTranslationDir(dirent.name),
-        )
+        .filter((dirent) => dirent.isDirectory() && isValidLocale(dirent.name))
         .map((dirent) => path.resolve(targetCtx.abspath, dirent.name));
 
       const translationFilePaths = (

src/lib/run-context/loader.ts

@@ -43,9 +43,6 @@ const evaluateRecursively = async (
     } else if (await MessageType.isMessageTypeDir(currDir)) {
       ctx.resourceDir = buildResourceDirContext("message_type", currDir);
     } else if (Translation.isTranslationDir(currDir)) {
-      // NOTE: Must keep this check as last in the order of directory-type checks
-      // since the `isTranslationDir` only checks that the directory name is a
-      // valid locale name.
       ctx.resourceDir = buildResourceDirContext("translation", currDir);
     }
   }

test/lib/marshal/translation/helpers.test.ts

@@ -5,13 +5,28 @@ import { isTranslationDir } from "@/lib/marshal/translation";
 
 describe("lib/marshal/translation/helpers", () => {
   describe("isTranslationDir", () => {
-    describe("given a path with a valid locale code", () => {
+    describe("given a path with a valid locale code under a translations parent", () => {
       it("returns true", () => {
         const path = xpath("/translations/fr-FR");
         expect(isTranslationDir(path)).to.be.true;
       });
     });
-    describe("given a path with an invalid locale code", () => {
+
+    describe("given a path with a valid locale code under a non-translations parent", () => {
+      it("returns false", () => {
+        const path = xpath("/Users/mr/my-project");
+        expect(isTranslationDir(path)).to.be.false;
+      });
+    });
+
+    describe("given a locale-code directory name as a username in the path", () => {
+      it("returns false", () => {
+        const path = xpath("/home/mr");
+        expect(isTranslationDir(path)).to.be.false;
+      });
+    });
+
+    describe("given an invalid locale code under a translations parent", () => {
       it("returns false", () => {
         const path = xpath("/translations/fake-lang");
         expect(isTranslationDir(path)).to.be.false;