Skip to content

fix(tabs): filename edits, min-widths, scrolling, content sync.#91

Merged
knightedcodemonkey merged 2 commits intonextfrom
bananas
Apr 23, 2026
Merged

fix(tabs): filename edits, min-widths, scrolling, content sync.#91
knightedcodemonkey merged 2 commits intonextfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 19:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the workspace tabs UX by making tab renames path-aware (including directory changes), adjusting tab sizing for crowded strips, and hardening editor content syncing during rapid tab switching/removal.

Changes:

  • Allow rename inputs to start from the full tab path and support directory changes during renames.
  • Adjust tab/input sizing to better handle many open tabs.
  • Fix tab editor content syncing under rapid tab churn; add Playwright coverage for the new behaviors.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/styles/panels-editor.css Tweaks tab strip/tab rename input sizing for crowded tab scenarios.
src/modules/workspace/workspace-tab-helpers.js Updates module rename path normalization to accept full-path inputs.
src/modules/app-core/workspace-tabs-renderer.js Starts rename input with tab.path (fallback to name) for path-aware edits.
src/modules/app-core/workspace-tab-mutations-controller.js Expands rename handling to support directory changes and keep name/path in sync.
src/modules/app-core/workspace-editor-helpers.js Adjusts editor-to-tab content persistence to reduce cross-tab content leakage.
playwright/workspace-tabs.spec.ts Adds tests for path-aware renames and rapid tab churn content isolation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/modules/workspace/workspace-tab-helpers.js
Comment thread src/modules/app-core/workspace-tab-mutations-controller.js
Comment thread src/modules/app-core/workspace-tab-mutations-controller.js
@knightedcodemonkey knightedcodemonkey merged commit 5716779 into next Apr 23, 2026
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch April 23, 2026 19:50
knightedcodemonkey added a commit that referenced this pull request May 2, 2026
* feat: idb infrastructure. (#63)

* feat: dynamic tabs. (#64)

* refactor: better accessbility for tabs. (#68)

* feat: remove allow-same-origin for better security. (#69)

* feat: tab reordering via drag-n-drop. (#70)

* feat: explicit css imports, diagnostics per editor buffer. (#71)

* feat: idb + github sync with atomic open and push to remote. (#78)

* closes #73, closes #74, closes #75.

* refactor: more colocation and smaller file sizes. (#79)

* refactor: improvements with styles and gh syncs. (#82)

* test: webkit flake. (#83)

* test: address flake. (#84)

* refactor: github pr context. (#85)

* fix: require app in entry, hide workspaces without pat, remove star important. (#86)

* feat: make idb source of truth for pr context. (#87)

* fix: active pr context on reload and dedupe workspace identity. (#88)

* fix: edited and push sync across reloads. (#89)

* fix: properly commit tab name changes. (#90)

* fix(tabs): filename edits, min-widths, scrolling, content sync. (#91)

* feat: improved workspace disconnect and closed ux. (#92)

* refactor: status styling and biome config. (#94)

* fix(diagnostics): enforce current-editor snapshots and stale results. (#95)

* fix: consistent head handling. (#96)

* fix: prevent workspace overwrites. (#100)

* fix(playwright): stabilize lint diagnostics waits with one-time rerun fallback. (#101)

* feat: improved workspace ux and state identity separation.  (#103)

* fix: iframe protocol mismatch in receiver reads. (#104)

* refactor: remove remaining fixed editor assumptions. (#105)

* refactor: simplify PR close flow with deterministic workspace state updates (#106)

* feat: mode-aware entry tab extensions. (#108)

* feat: workspace status bar. (#109)

* feat: tab-scoped ai chat. (#111)

* refactor: better workspace drawer ux. (#112)

* refactor: remove collapsible editors and update breakpoint styles. (#113)

* docs: update for vnext. (#114)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants