Skip to content

Conversation

@dprotaso
Copy link
Member

Follow up to #3295

This will trigger the http server to close the connection https://cs.opensource.google/go/go/+/refs/tags/go1.25.4:src/net/http/server.go;l=1389-1391

I'm going to hold this PR and see if we need it

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2025
@dprotaso
Copy link
Member Author

/hold

@knative-prow
Copy link

knative-prow bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from creydr November 26, 2025 17:54
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025
@knative-prow knative-prow bot requested a review from Leo6Leo November 26, 2025 17:54
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.57%. Comparing base (e853b1d) to head (33177e0).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
network/handlers/drain.go 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3297      +/-   ##
==========================================
- Coverage   74.58%   74.57%   -0.01%     
==========================================
  Files         188      188              
  Lines        8187     8185       -2     
==========================================
- Hits         6106     6104       -2     
  Misses       1841     1841              
  Partials      240      240              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member Author

Closing this out - I haven't seen webhook EOFs since I removed the disabling of keep alives

@dprotaso dprotaso closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant