feat: use centralized TLS configuration from knative/pkg/tls#8901
Open
Fedosin wants to merge 1 commit intoknative:mainfrom
Open
feat: use centralized TLS configuration from knative/pkg/tls#8901Fedosin wants to merge 1 commit intoknative:mainfrom
Fedosin wants to merge 1 commit intoknative:mainfrom
Conversation
|
There are empty aliases in OWNER_ALIASES, cleanup is advised. |
knative-prow
bot
added
the
size/XXL
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8901 +/- ##
==========================================
+ Coverage 50.67% 50.72% +0.04%
==========================================
Files 409 409
Lines 21694 21708 +14
==========================================
+ Hits 10994 11011 +17
+ Misses 9848 9845 -3
Partials 852 852 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
/hold blocked by #8900 |
knative-prow
bot
added
the
do-not-merge/hold
knative-prow
bot
added
size/L
Bump knative.dev/pkg to pick up the new knative.dev/pkg/tls package and replace the hardcoded TLS server config in eventingtls with the shared DefaultConfigFromEnv utility. This enables environment-based control of MinVersion, MaxVersion, CipherSuites, and CurvePreferences for all eventing TLS servers (broker filter/ingress, IMC dispatcher, job sink, auth proxy, request-reply). Since DefaultConfigFromEnv defaults to TLS 1.3 but eventing historically defaults to TLS 1.2, GetTLSServerConfig falls back to 1.2 unless TLS_MIN_VERSION is explicitly set. Also wires up TLS for the RequestReply data plane, which previously had a TODO placeholder. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
Author
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fedosin, twoGiants The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Bump knative.dev/pkg to pick up the new knative.dev/pkg/tls package and replace the hardcoded TLS server config in eventingtls with the shared DefaultConfigFromEnv utility. This enables environment-based control of MinVersion, MaxVersion, CipherSuites, and CurvePreferences for all eventing TLS servers (broker filter/ingress, IMC dispatcher, job sink, auth proxy, request-reply).
Since DefaultConfigFromEnv defaults to TLS 1.3 but eventing historically defaults to TLS 1.2, GetTLSServerConfig falls back to 1.2 unless TLS_MIN_VERSION is explicitly set.
Also wires up TLS for the RequestReply data plane, which previously had a TODO placeholder.
Pre-review Checklist
Release Note
Docs