Fix tooltip on <img> and other replaced elements#86
Open
laurentbardin wants to merge 1 commit intoknadh:masterfrom
Open
Fix tooltip on <img> and other replaced elements#86laurentbardin wants to merge 1 commit intoknadh:masterfrom
laurentbardin wants to merge 1 commit intoknadh:masterfrom
Conversation
laurentbardin
changed the title
Tooltips use `::before` and `::after`, which cannot work on replaced elements, the most common of which is `<img>`. We skip those elements when initialising the tooltips so that their `title` attribute is not removed and it can still be displayed by the browser when hovering over them.
laurentbardin
force-pushed
the
fix-tooltip-on-replaced-elements
branch
from
791869d to
94e893b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
::beforeand::afterto manage tooltips can't work on replaced elements, the most common of those being<img>.We should skip those elements in order to preserve their
titleattribute so that the default browser behaviour still works and the tooltip text can be displayed.Alternatively, we could still add the
data-tooltiporaria-labelattribute (or both), and simply skip the removal of thetitleattribute.