Conversation
imgk
force-pushed
the
udpinhttp
branch
2 times, most recently
from
4d46ff7 to
02e512b
Compare
forwardproxy.go
Outdated
| h.udpProxyServer = &udpProxyServer{} | ||
| // parse http2/http3 uri template | ||
| if h.URITemplate == "" { | ||
| h.uriTemplate = uritemplate.MustNew("https://{host}/.well-known/masque/udp/{target_host}/{target_port}/") |
There was a problem hiding this comment.
Is it necessary to introduce a library for this? Can you use simpler functions?
forwardproxy_udp.go
Outdated
| return Request(net.JoinHostPort(targetHost, strconv.Itoa(targetPort))), nil | ||
| } | ||
|
|
||
| func (h *Handler) checkACL(hostPort string) (bool, error) { |
There was a problem hiding this comment.
Seems to have duplicated forwardproxy.go.
I think much of this should be embedded along side the logic of tcp/http.
imgk
force-pushed
the
udpinhttp
branch
13 times, most recently
from
0aa5ca1 to
95737ac
Compare
imgk
force-pushed
the
udpinhttp
branch
2 times, most recently
from
30eb2ff to
6b9937e
Compare
imgk
force-pushed
the
udpinhttp
branch
6 times, most recently
from
e7abc00 to
c3819b0
Compare
|
any update? |
|
Review comments are not addressed yet. |
|
How is it now? This PR looks very interesting, does the naiveproxy client need to be modified? |
|
I asked for not duplicating forwardproxy.go into a udp version, and there was no answer for that. |
Hi, I misunderstood your request there. I believe this is done now. |
|
Hi @imgk, Does this feature require any changes to the client? Or does it already support the client that complies with the RFC definition? |
Hi, this modified |
Fixes caddyserver#170 - Update `dial_timeout` example to use duration unit (30s) - Change parameter type from [integer] to [Duration] to match Go type - Update description to clarify duration unit requirement This change makes the documentation more accurate and consistent with Go's time.Duration type usage.
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/golang/glog](https://github.com/golang/glog) from 1.2.0 to 1.2.4. - [Release notes](https://github.com/golang/glog/releases) - [Commits](golang/glog@v1.2.0...v1.2.4) --- updated-dependencies: - dependency-name: github.com/golang/glog dependency-version: 1.2.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
How is the status of the PR now? |
5 participants
1. What does this change do, exactly?
Add UDP in HTTP support
2. Please link to the relevant issues.
klzgrad/naiveproxy#617
3. Which documentation changes (if any) need to be made because of this PR?
4. Checklist