Switch to ember-auto-import and Babel 7#198
Merged
kiwiupover merged 2 commits intokiwiupover:masterfrom Oct 31, 2018
Merged
Conversation
Owner
|
WAHOO!! |
Contributor
Author
|
@kiwiupover I hate to say this, but have you successfully tested this in an app? I'm seeing a weird issue in my tests trying to use this. Didn't get back here in time to warn you! |
Owner
|
@wagenet I did run it in a dummy app. It was fine there. I have not pushed a new npm version so we are all good. I will look at it in the next few days |
Contributor
Author
|
@kiwiupover If I find any bug in this stuff I'll submit another PR for it. Might have just unearthed something strange in my own app. |
Owner
|
@wagenet interesting |
Contributor
Author
|
Looks like there's an issue with broccoli-asset-rewrite and ember-auto-import. Trying to see if I can fix the issue in broccoli-asset-rewrite. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.