Skip to content

Fix kiwi://extensions on small screens#732

Open
bershanskiy wants to merge 1 commit intokiwibrowser:kiwifrom
bershanskiy:fix-extensions-options
Open

Fix kiwi://extensions on small screens#732
bershanskiy wants to merge 1 commit intokiwibrowser:kiwifrom
bershanskiy:fix-extensions-options

Conversation

@bershanskiy
Copy link
Copy Markdown

This was not tested on real build yet (waiting for CI)

This PR fixes visual issues of kiwi://extensions on small screens (less than 400 virtual pixels):

  • the developer toggle is not visible because the label itself takes its place
    There was a way to access the toggle, but it was not intuitive (click on "search" icon to hide page label, then hold and swipe the toggle).
  • the extension cards are too wide and do not fit the screen

Before

Screenshot made on Kiwi 105.0.5195.33 on Samsung Galaxy S20 FE:
Screenshot_20221014-175700_Kiwi Browser

After:

Screenshot made on Chromium on PC (real Kiwi screenshot coming later):
image

@bershanskiy
Copy link
Copy Markdown
Author

@kiwibrowser I would appreciate if you could trigger CI build, since GitHub Actions on my fork do not have necessary token and I couldn't find docs about building Kiwi from full source on Linux (or any other platform).

@bershanskiy
Copy link
Copy Markdown
Author

This is basically a "hello world" PR to test out build system and process while fixing a minor thing.

Copy link
Copy Markdown

@Huge Huge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly good, have not tested myself either, though.

--cr-toolbar-field-width: 100%;
}

/* On small screens hide the toggle label so to live space for toggle itself. */
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*hide the toggle label to leave space

}

/* On small screens hide the toggle label so to live space for toggle itself. */
@media (max-width: 400px) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure setting a (large enough though )constant is a good practice.

@Huge
Copy link
Copy Markdown

Huge commented Nov 12, 2022

Great effort!
Seems you have missed that src.next is made by the same team as the old src KiwiBrowser, where there is extensive guide, I'm just going through it.
Please join https://matrix.to/#/#kiwibrowser-fans-building-it:matrix.org to talk/coordinate our efforts!+)

@kiwibrowser kiwibrowser force-pushed the kiwi branch 4 times, most recently from e443cb4 to 32dfc33 Compare January 23, 2025 10:49
Repository owner deleted a comment from ByteJoseph Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants