This repository was archived by the owner on Feb 16, 2026. It is now read-only.
Fix Mapping Service Settings handling#56
Open
GGoetzelmann wants to merge 1 commit intodevelopmentfrom
Open
Conversation
unified URL handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following bugs:
showServiceURLtotrueis overwritten by faulty and obsolete applyConfig call (where serviceURL is always undefined).ajaxBaseURLvia settings file is not reflected in the service URL input field. The input field always shows the hard-coded base-url "http://localhost:8095/" instead.This PR contains the following improvements:
setURL()function instead of directly via DOM element. Not sure if this is the most elegant solution, feel free to change.This PR does NOT address the following bugs: