Clean up and update Gradle setup#1
Merged
Merged
Conversation
The daemon is a useful tool, and the only reason it was so often disabled in the past was ForgeGradle issues
In general, text files should all be LF in the index, and then you can use your git settings to check out as your local line endings (this should be the default) and let git commit the right stuff
… update plugins, enable configuration caching A first pass for consistency, and getting everything working on latest gradle and plugin versions
This complies with gradle best practice: https://docs.gradle.org/current/userguide/best_practices_structuring_builds.html#favor_composite_builds
IDEA-317606 was fixed in IJ 2023.3.4
…o single source of truth System.getenv() is a bad idea with config cache, and use of timestamps requires being careful. In fact, I've removed the use of timestamps altogether in places where they hamper reputability more generally. Changing the project names to match published coordinates simplifies calculating capabilities and artifact names and the like without needing to explicitly specify any of those.
Contributor
Author
|
Note: this changes the coordinates the template publishes under to be more consisent. That can be changed back without too much issue by using the old root name to build the project names instead of the mod ID. |
…ituations where the two may differ (mod IDs with underscores, say)
Contributor
|
All looks amazing to me, had a little tinker around and nothing seems wrong and I like what you've done with the fixes/changes :D Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some general cleanups and updates to the Gradle setup:
gradlewexecutable (withchmod +x gradlew). This is necessary for using the template from the CLI in a unix-like environment.artifactIdandarchivesNamedeclarations. By setting the project names to sensible defaults, all of these are derived automatically as we would like. The IDEA bug that used to prevent this has been fixed for two years.