TypeError: Cannot read property "require" of undefined#55
Open
RZulfikri wants to merge 1 commit intokirillzyusko:masterfrom
Open
TypeError: Cannot read property "require" of undefined#55RZulfikri wants to merge 1 commit intokirillzyusko:masterfrom
RZulfikri wants to merge 1 commit intokirillzyusko:masterfrom
Conversation
prevent undefined value
Author
|
here is the error that I found, cc @kirillzyusko |
Owner
|
Hi @RZulfikri Thanks for submitting a PR! Could you please say, how it's possible to call Would be great if you could provide a minimal reproduction example of the issue 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi I found an issue that spam our sentry and development screens.
After few testing on this liblary I found that
mapLoadable[name]can be undefined. So when you extract withconst {require, loader, ...} = mapLoadable[name]it will trow an error.react-native-bundle-splitter/src/map.ts
Line 31 in c44c7bd
I'm trying to fix this by adding condition on top of that code, by cheking
mapLoadable[name]exist, before extract the value.