Skip to content

Conversation

@krajczardavid
Copy link

No description provided.

Copy link
Member

@albi005 albi005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

this looks really good but i'd like to keep the news column the main focus of the page. using a high-chroma color puts too much emphasis on this card


Image Image

try to keep the same density as the old design

@@ -1,3 +1,8 @@
* {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* {
:root {

<a href="/">
<Title>
StartSCH
<WordmarkLogo/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Title is just a convenience component that renders its content to both the <title> element in the <head> and a <h1> in its place so this will probably not work


@code {
[Parameter, EditorRequired] public required RenderFragment ChildContent { get; set; }
[Parameter] public String ButtonStyle { get; set; } = "outlined";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Parameter] public String ButtonStyle { get; set; } = "outlined";
[Parameter] public string ButtonStyle { get; set; } = "outlined";

<a href="/">
<Title>
StartSCH
<WordmarkLogo/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

body {
background: var(--md-sys-color-surface);
background-color: var(--startsch-sys-color-page-bg);
/* background: var(--md-sys-color-surface); */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later on i want to add dynamic coloring so please try to stick to the default color roles from m3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants