Add transfrom and upgrade preview in SelectCardsInHandAction#105
Open
Celicath wants to merge 2 commits intokiooeht:developfrom
Open
Add transfrom and upgrade preview in SelectCardsInHandAction#105Celicath wants to merge 2 commits intokiooeht:developfrom
Celicath wants to merge 2 commits intokiooeht:developfrom
Conversation
- Add a new overload with forTransform and forUpgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit
Add
forTransformandforUpgradeparameters, which is used inHandCardSelectScreen::open.The following is what happens If you set
forUpgradetotrue.The second commit
Allows you to provide a custom preview function. Basegame's
forUpgradeonly supports upgrades, but this allows you to preview with other modifiers as well.I'm not sure if adding a single overload is enough, but I did it this way because there are too many constructor overloads already.