Fix broken route and resource generators #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g part This part of the test fails due to app/route.coffee not existing
| .then(() => expect(file('app/router.coffee')) | ||
| .to.not.contain("@route 'foo'")); | ||
| // .then(() => expect(file('app/router.coffee')) | ||
| // .to.not.contain("@route 'foo'")); |
Contributor
There was a problem hiding this comment.
Should these comments remain? (in both files)
Contributor
Author
There was a problem hiding this comment.
I think they should be kept as a reminder that the router part should also be tested, I just don't know how to do it in a simple way. Similar to the old test that was skipped.
Contributor
|
The |
Contributor
Author
|
@olleolleolle The errors reported for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #146 by fixing the
routegenerator to uselocalsfrom the ancestral blueprint.It also enables two previously skipped tests by removing the parts of the tests that would fail due to
app/router.coffeenot existing.