Skip to content

Conversation

@reshmabidikar
Copy link
Contributor

@reshmabidikar reshmabidikar commented May 9, 2025

Work for #145.

Edit: 2025-05-28: I did some more investigations and I think the system works as expected. See this comment.

I've tested this from the hello-world-plugin. See this PR. So, I can access KB healthcheck and plugins healthcheck from the hello-world-plugin. However, I'm unable to check the health of an individual plugin like Aviate. (See this line).

So a few questions:

  • Do the changes in this PR look good?
  • Is the testing approach correct?
  • Should we be able to access healthcheck for an individual plugin like Aviate like done here?

@reshmabidikar reshmabidikar marked this pull request as ready for review May 9, 2025 06:25
@sbrossie
Copy link
Member

sbrossie commented May 9, 2025

What do you see when you print the names here ?

@reshmabidikar
Copy link
Contributor Author

What do you see when you print the names here ?

This is what I see:

[main.pool.ConnectivityCheck, org.killbill.billing.server.healthchecks.KillbillHealthcheck, org.killbill.billing.server.healthchecks.KillbillPluginsHealthcheck, org.killbill.billing.server.healthchecks.KillbillQueuesHealthcheck, osgi.pool.ConnectivityCheck, shiro.pool.ConnectivityCheck]

Copy link
Member

@sbrossie sbrossie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to also make this service available from the KillbillActivatorBase - if not do we expect, plugins to use ServiceTracker apis to fetch the OCGI bundle?

@reshmabidikar
Copy link
Contributor Author

Don't we need to also make this service available from the KillbillActivatorBase - if not do we expect, plugins to use ServiceTracker apis to fetch the OCGI bundle?

Made changes in the code to make the HealthCheckRegistry available in KillBillActivatorBase. See 92e334d. Verified that the HealthCheckRegistry is available via KillBillActivatorBase in the hello-world-plugin. See this commit.

@sbrossie sbrossie merged commit 5ab9d02 into killbill:master Jun 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants