Adyen address validation #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A setter should not change a field value just to avoid validation issues: if data are invalid, they should be explicitely fixed in the data source.
As per Adyen documentation, the billing address per se is optional [1], but when sending it, the country is always mandatory, while the remaining fields must either be sent all or none [2] (although in our experience the ZIP always has been treated as optional by Adyen: maybe it is mandatory only for US and CA). This commit makes the address validation compliant (altough still only validates the data presence, not the *values* formal correctness). [1] https://docs.adyen.com/api-reference/payments-api/paymentrequest/ [2] https://docs.adyen.com/api-reference/common-api/address/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Adyen plugin we had an unexpected behavior with the address validation. It turned out that the plugin was silently changing the data just to pass the validation in one specific use case.
Moreover, the criteria used to determine if the billing address should whether be sent or not were not compliant with the Adyen documentation.
This pull request should address both issues.
I'm not sure of the impact on backward compatibility, but IMHO relying on plugin's opaque behavior to get things done is not a good idea (e.g. it costed us some time to figure out what was happening).