Add -I/--important flag to new command#87
Open
underwear wants to merge 1 commit intokiblee:masterfrom
Open
Conversation
Adds support for creating tasks with high importance via the `-I`/`--important` flag on the `new` command. When set, sends `"importance": "high"` in the Graph API request body. Closes kiblee#84
underwear
force-pushed
the
add-important-flag
branch
from
666dc86 to
dfb1681
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-I/--importantboolean flag to thenewcommand"importance": "high"in the Graph API request body using the existingTaskImportanceenum"normal"importance when flag is not providedUsage
Changes
todocli/cli.py— add-I/--importantargument, pass it tocreate_task()todocli/graphapi/wrapper.py— acceptimportantparam, set"importance"field in request bodytests/test_cli_commands.py— 4 new tests for the flag (short, long, default, combined with other flags)Test plan
python -m pytest tests/test_cli_commands.py)black --checkpasses on all changed filestodocli new -I "TEST important"→ verifiedimportance: "high"via APICloses #84