Simplified by using a table view controller and reloading on app resume. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a table view controller the keyboard is handled automatically which significantly simplifies the class. The settings table was removed and all keyboard notifications removed. Instead it uses the built-in table. Now it handles the case of leaving the app and changing a setting in preferences, when resuming the app the settings will reload to show the change.
By using a table view controller the keyboard is handled automatically which significantly simplifies the class. The settings table was removed and all keyboard notifications removed. Instead it uses the built-in table. Now it handles the case of leaving the app and changing a setting in preferences, when resuming the app the settings will reload to show the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using a table view controller the keyboard is handled automatically which significantly simplifies the class. The settings table was removed and all keyboard notifications removed. Instead it uses the built-in table.
Now it handles the case of leaving the app and changing a setting in preferences, when resuming the app the settings will reload to show the change.