Fix unicode messages#47
Conversation
There was problem with unicode messages. That is fixed by verifying that incoming variable is basestring (not str) and in case it is not, then we convert variable to unicode (not to str).
|
Thanks for the catch. Which version of Python were you using ? Did you run the unit tests through Tox to test all the versions? I'll try to run through the tests myself sometime this week. |
|
Sorry, I didn't run tests on all versions, but basestring was first introduced in version 2.3, but it is no longer available in Python 3. I will update code to pass in all versions of python you have defined in Tox. |
|
I know the Six library does a few things to check basestring vs str Not sure how we would want to do this here without poking at it some myself. I wonder why it wasn't caught by my existing unicode test https://github.com/kfdm/gntp/blob/master/gntp/test/basic_tests.py#L47 Do you have an example message that failed ? |
|
I'm pretty sure that this will fail, but I was using different text: u"Šaursliežu dzelzceļš" |
|
BTW, I didn't use six library, but instead try except. I didn't test it with Tox as I don't have it installed. Let me know if there is anything else I can help. |
2 participants
There was problem with unicode messages. That is fixed by verifying that incoming variable is basestring (not str) and in case it is not, then we convert variable to unicode (not to str).