Improve release notes order and binary install flow#3
Merged
Conversation
Use default commit-history ordering for GoReleaser changelog output and add a portable install script with simplified README one-liners for prebuilt binary installation. Made-with: Cursor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5dd8f39. Configure here.
| Install a specific version: | ||
|
|
||
| ```bash | ||
| VERSION=v0.1.0 curl -fsSL "https://raw.githubusercontent.com/keyskey/gobce/main/scripts/install.sh" | sh |
There was a problem hiding this comment.
Environment variables not propagated to piped sh process
High Severity
The VERSION and INSTALL_DIR variables in the install commands are not passed to the sh process. Shell prefix assignments (VAR=value cmd) only apply to the immediate command, not commands in a pipe. This causes the install script to silently ignore the user's specified version or install directory, falling back to defaults.
Reviewed by Cursor Bugbot for commit 5dd8f39. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
scripts/install.shto install prebuilt binaries with auto-detected OS/arch and optionalVERSION/INSTALL_DIRTest plan
sh -n scripts/install.shgobceinstall script logic reviewed for darwin/linux amd64/arm64 pathsMade with Cursor
Note
Low Risk
Low risk: release metadata and documentation updates plus a new standalone install script; main runtime code paths are unchanged.
Overview
Release notes generation is adjusted by removing the explicit changelog sorting in
.goreleaser.yml, allowing notes to follow git commit chronology.Adds
scripts/install.sh, a POSIXshinstaller that auto-detects OS/arch, resolves the latest (orVERSION-pinned) GitHub Release, downloads the matchingtar.gz, and installs it to/usr/local/bin(orINSTALL_DIR).Updates
README.mdto use one-linecurl | shexamples for installing prebuilt binaries, including version pinning and custom install directory.Reviewed by Cursor Bugbot for commit 5dd8f39. Bugbot is set up for automated code reviews on this repo. Configure here.