Skip to content

Connect Elasticsearch cluster via HTTP API with Basic Auth#13

Merged
alanthssss merged 4 commits into
mainfrom
copilot/connect-elasticsearch-cluster
Mar 31, 2026
Merged

Connect Elasticsearch cluster via HTTP API with Basic Auth#13
alanthssss merged 4 commits into
mainfrom
copilot/connect-elasticsearch-cluster

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 31, 2026

  • Explore repository structure and understand codebase
  • Add ElasticsearchConfig struct (addresses, username, password) to config/config.go
  • Update LoadConfig to return *AppConfig with structured ES config + all other service configs
  • Add checker/elasticsearch.go with HTTP-based CheckElasticsearch (Basic Auth support)
  • Update main.go to use new AppConfig and call ES checker for elasticsearch service
  • Update config.yml and docker/config.yml to use new structured elasticsearch format
  • Update docker/docker-compose.yml to enable xpack security + set ELASTIC_PASSWORD for Elasticsearch
  • Update README.md to document the new elasticsearch config format
  • Merge origin/main (Redis, MinIO, Kibana, ZooKeeper, Kafka features) and resolve all conflicts
  • Fix indentation: apply gofmt to all Go files (config/config.go, main.go, checker/zookeeper.go)

Copilot AI linked an issue Mar 31, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Connect Elasticsearch cluster with password authentication Connect Elasticsearch cluster via HTTP API with Basic Auth Mar 31, 2026
Copilot AI requested a review from alanthssss March 31, 2026 16:17
Copy link
Copy Markdown
Member

@alanthssss alanthssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanthssss
Copy link
Copy Markdown
Member

@copilot solve the merge conflicts

…icsearch-cluster

# Conflicts:
#	README.md
#	config.yml
#	config/config.go
#	docker/config.yml
#	main.go

Co-authored-by: alanthssss <32271197+alanthssss@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 31, 2026

@copilot solve the merge conflicts

Resolved in 93e00bd. Merged origin/main into this branch, combining all the Redis/MinIO/Kibana/ZooKeeper/Kafka features from main with the Elasticsearch HTTP+password changes from this PR. All conflicts resolved, build and tests pass.

@alanthssss alanthssss marked this pull request as ready for review March 31, 2026 17:33
Copilot AI requested a review from alanthssss March 31, 2026 17:34
@alanthssss
Copy link
Copy Markdown
Member

@copilot plz check the indent in code. it is important for read. thx

Agent-Logs-Url: https://github.com/keyscome/pulse/sessions/108c330e-5f23-451a-9057-eb6b761c4c95

Co-authored-by: alanthssss <32271197+alanthssss@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 31, 2026

@copilot plz check the indent in code. it is important for read. thx

Fixed in 01b8acf. Ran gofmt -w . across all Go files — config/config.go and main.go were missing tabs throughout (struct fields, function bodies), and checker/zookeeper.go had an extra blank line. All corrected.

Copy link
Copy Markdown
Member

@alanthssss alanthssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread config/config.go Outdated
Comment on lines +15 to +17
Addresses []string `yaml:"addresses"`
Username string `yaml:"username"`
Password string `yaml:"password"`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the indent is disapperd? we know it is not important in golang, but which should is good for read.
@copilot

Comment thread config/config.go Outdated
Comment on lines +22 to +24
Addresses []string `yaml:"addresses"`
Username string `yaml:"username"`
Password string `yaml:"password"`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same indent issue @copilot

Comment thread config/config.go Outdated
Comment on lines +29 to +32
Username string `yaml:"username"`
Password string `yaml:"password"`
UseSSL bool `yaml:"use_ssl"`
Addresses []string `yaml:"addresses"`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same indent issue @copilot

Comment thread main.go Outdated
Comment on lines +5 to +14
"bytes"
"fmt"
"os"
"text/template"
"time"

"github.com/keyscome/pulse/checker"
"github.com/keyscome/pulse/config"
"github.com/keyscome/pulse/kafka"
"github.com/keyscome/pulse/logger"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same indent issue @copilot

@alanthssss alanthssss merged commit c3cfdde into main Mar 31, 2026
@alanthssss alanthssss deleted the copilot/connect-elasticsearch-cluster branch March 31, 2026 17:42
Copilot stopped work on behalf of alanthssss due to an error March 31, 2026 17:42
Copilot AI requested a review from alanthssss March 31, 2026 17:42
@alanthssss alanthssss restored the copilot/connect-elasticsearch-cluster branch March 31, 2026 17:42
@alanthssss alanthssss deleted the copilot/connect-elasticsearch-cluster branch March 31, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connect Elasticsearch

2 participants