Conversation
Note: this removes the non-docker configuration, to reduce maintenance. Development version runs in two containers in order to simplify live-reload. Production version will run in a single container. See README.md for details of usage. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
|
Not directly related to this PR but triggered by it: I only skimmed over the changes and realized that I'm not clear how it's split up in two containers. Looking at the existing documentation I get an idea how it's probably done. I think at some point we should improve the readme and add a few sentences explaining what we understand here as server and client (server=backend running on the server, client=frontend running in the browser?) and which directories implement that (I guess since there is a |
| } | ||
|
|
||
| function stop_docker_containers() { | ||
| rm -f ./_control/ready |
There was a problem hiding this comment.
Why wouldn't this be in clean_docker_containers?
There was a problem hiding this comment.
Because once the site is down, it is no longer ready -- it could go in clean as well I guess?
|
If we want to use status.keyman.com.localhost for local dev, https://github.com/keymanapp/website-local-proxy/blob/master/resources/nginx.conf |
For now, as we need to keep the deployment to Azure working, update the workflows to use the new script locations. Test first on staging.
|
Note: I have changed base to staging (https://com-keyman-staging-status.azurewebsites.net/) while we test this, to make sure that the deployment doesn't break the main status.keyman.com site. I will follow up with a production PR once we are confident that the azure deployment still works. |
Note that the changes to build.sh prologue should be replicated across our other sites to give additional stability. Co-authored-by: Eberhard Beilharz <eb1@sil.org>
|
@ermshiperete added some docs in README.md |
|
|
||
| Three files are needed for development: | ||
|
|
||
| * `.keymanapp-test-bot.appid`: integer appid (e.g. 134443 for the normal test app) |
There was a problem hiding this comment.
How do I get that appid?
There was a problem hiding this comment.
Getting these files involves installing the app on your own account, e.g. I have it installed for keymanapp at https://github.com/organizations/keymanapp/settings/apps/keymanapp-test-bot.
| npm install | ||
| npm run-script build | ||
| cd .. | ||
| ./build.sh stop build --debug |
There was a problem hiding this comment.
is it necessary to specify --debug or is that the default (as it is with the builder scripts in the keyman repo)?
There was a problem hiding this comment.
Currently, --debug is not default.
4 participants
Note: this removes the non-docker configuration, to reduce maintenance.
Development version runs in two containers in order to simplify live-reload. Production version will run in a single container.
See README.md for details of usage.
Depends-on: #600
Test-bot: skip