fix(linux): include missing artifacts in source tarball 🗜️ #15566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change it's possible to build Keyman from the source tarball by running `./build.sh` from the Keyman root directory. When building Keyman as part of the Ubuntu/Debian packaging, we don't use the toplevel `build.sh` file but instead call the build scripts in the subdirectories. This omits building some components that are currently not needed for running Keyman for Linux. The `dist.sh` script only includes the necessary files in this case, distinguished by the `origdist` parameter. This results in a significantly smaller tarball (2.5MB vs 51MB). This change also enhances the `generate_tar_ignore_list` function so that it is now possible to add `build` to the exclude list to ignore all `build` subdirectories. Fixes: #15544 Build-bot: skip Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
requested changes
Feb 5, 2026
Comment on lines
156
to
198
| function _is_exact_match() { | ||
| local var="$1" | ||
| local needle="$2" | ||
| local array="${var}[@]" | ||
| local haystack=("${!array}") | ||
| local item | ||
| for item in "${haystack[@]}"; do | ||
| if [[ "./${item#./}" == "${needle}" ]]; then | ||
| return 0 | ||
| fi | ||
| done | ||
| return 1 | ||
| } | ||
|
|
||
| function _starts_with() { | ||
| local var="$1" | ||
| local start="$2" | ||
| local array="${var}[@]" | ||
| local values=("${!array}") | ||
| local item | ||
| for item in "${values[@]}"; do | ||
| if [[ "./${item#./}" == ${start}* ]]; then | ||
| return 0 | ||
| fi | ||
| done | ||
| return 1 | ||
| } | ||
|
|
||
| function _ends_with() { | ||
| local array_var="$1" | ||
| local file="$2" | ||
| local array="${array_var}[@]" | ||
| local values=("${!array}") | ||
| local item | ||
| for item in "${values[@]}"; do | ||
| if [[ "${file}" == */${item#./} ]]; then | ||
| return 0 | ||
| fi | ||
| done | ||
| return 1 | ||
| } | ||
|
|
||
| function _is_wildcard_match() { |
Member
There was a problem hiding this comment.
I'd like to see unit tests for these eminently testable functions 😁
Contributor
Author
There was a problem hiding this comment.
Ah yes, good point. Done.
darcywong00
reviewed
Feb 6, 2026
| } | ||
|
|
||
| function debug() { | ||
| # echo "$@" |
Contributor
There was a problem hiding this comment.
Do you have access to check builder local and debug options?
Contributor
Author
There was a problem hiding this comment.
I don't think so since it's not a full builder script.
This change adds the `assert-true` and `assert-false` function to our bash testing framework, together with unit tests. Also rename the test file to `testing-framework.inc.tests.sh` to match the implementation file.
This addresses code review comments. Also improve variable naming and documentation for these new functions.
ermshiperete
added a commit
that referenced
this pull request
Feb 6, 2026
Using the xz compression instead of gzip greatly reduces the size of the tarball. Follows: #15566 Test-bot: skip
ermshiperete
added a commit
that referenced
this pull request
Feb 6, 2026
Using the xz compression instead of gzip greatly reduces the size of the tarball. Follows: #15566 Test-bot: skip
ermshiperete
changed the title
Co-authored-by: Marc Durdin <marc@durdin.net>
ermshiperete
added a commit
that referenced
this pull request
Feb 6, 2026
Using the xz compression instead of gzip greatly reduces the size of the tarball. Follows: #15566 Test-bot: skip
mcdurdin
approved these changes
Feb 6, 2026
ermshiperete
added a commit
that referenced
this pull request
Feb 9, 2026
chore(linux): use xz compression for source tarballs 🗜️ Using the xz compression instead of gzip greatly reduces the size of the tarball. Follows: #15566
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.201-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change it's possible to build Keyman from the source tarball by running
./build.shfrom the Keyman root directory.When building Keyman as part of the Ubuntu/Debian packaging, we don't use the toplevel
build.shfile but instead call the build scripts in the subdirectories. This omits building some components that are currently not needed for running Keyman for Linux. Thedist.shscript only includes the necessary files in this case, distinguished by theorigdistparameter. This results in a significantly smaller tarball (2.5MB vs 51MB).This change also enhances the
generate_tar_ignore_listfunction so that it is now possible to addbuildto the exclude list to ignore allbuildsubdirectories.Fixes: #15544
Build-bot: skip
Test-bot: skip