Skip to content

refactor(web): rename DefaultRules → DefaultOutputRules 📏 🎼 #15464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ermshiperete merged 4 commits into from
Jan 20, 2026
Merged

refactor(web): rename DefaultRules → DefaultOutputRules 📏 🎼 #15464

ermshiperete merged 4 commits into from
Jan 20, 2026
+39 −39

Conversation

@ermshiperete
Copy link
Contributor

@ermshiperete ermshiperete commented Jan 16, 2026 •
edited
Loading

This change renames DefaultRules → DefaultOutputRules.

Test-bot: skip

@ermshiperete ermshiperete requested a review from mcdurdin January 16, 2026 17:09
@github-project-automation github-project-automation bot moved this to Todo in Keyman Jan 16, 2026
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jan 16, 2026 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Android
    • Keyman for Android apk - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Android apk - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Android apk (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • KeyboardHarness apk - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for Android apk (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • KMSample1 apk - build : all tests passed (no artifacts on BuildLevel "build")
    • KMSample2 apk - build : all tests passed (no artifacts on BuildLevel "build")
  • Developer
    • Keyman Developer - build : all tests passed (no artifacts on BuildLevel "build")
    • Compiler Regression Tests - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman Developer (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • kmcomp.zip - build : all tests passed (no artifacts on BuildLevel "build")
    • kmcomp.zip (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • iOS
    • Keyman for iOS (simulator image) - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for iOS (simulator image) - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for iOS (simulator image) (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for iOS (simulator image) (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • Keyboards
    • Test Keyboards - build : all tests passed (no artifacts on BuildLevel "build")
  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot bot changed the title refactor(web): make ProcessorInitOptions.keyboardInterface mandatory refactor(web): make ProcessorInitOptions.keyboardInterface mandatory 🎼 Jan 16, 2026
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S20 milestone Jan 16, 2026
@ermshiperete ermshiperete changed the title refactor(web): make ProcessorInitOptions.keyboardInterface mandatory 🎼 refactor(web): rename DefaultRules → DefaultOutputRules 🎼 Jan 16, 2026
@ermshiperete ermshiperete force-pushed the refactor/web/defaultRules branch from aa5c5ba to f22faa1 Compare January 16, 2026 17:15
@ermshiperete ermshiperete changed the title refactor(web): rename DefaultRules → DefaultOutputRules 🎼 refactor(web): rename DefaultRules → DefaultOutputRules 📏 🎼 Jan 16, 2026
@keyman-server keyman-server modified the milestones: A19S20, A19S21 Jan 16, 2026
@ermshiperete
Copy link
Contributor Author

ermshiperete commented Jan 19, 2026 •
edited
Loading

Baseline tests fail because the expiry time of cookies is set to the past. Will be fixed with #15472.

@ermshiperete ermshiperete changed the base branch from epic/web-core to fix/web/baselinetests January 19, 2026 17:21
mcdurdin
mcdurdin approved these changes Jan 19, 2026
View reviewed changes
web/src/engine/src/keyboard/defaultOutputRules.ts Outdated
Comment on lines 144 to 149
let Lch: number;
if(Lkc.Lcode < 106) {
var Lch = Lkc.Lcode-48;
Lch = Lkc.Lcode-48;
} else {
Lch = Lkc.Lcode-64;
}
Copy link
Member

@mcdurdin mcdurdin Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

const Lch = (Lkc.Lcode < 106) ? Lkc.Lcode-48 : Lkc.Lcode-64;

Base automatically changed from fix/web/baselinetests to epic/web-core January 20, 2026 07:35
@ermshiperete ermshiperete merged commit bc6ea94 into epic/web-core Jan 20, 2026
15 of 16 checks passed
@ermshiperete ermshiperete deleted the refactor/web/defaultRules branch January 20, 2026 11:22
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

Assignees

No one assigned

Labels

epic-web-core refactor web/

Projects

Keyman
Archived in project

Milestone

A19S21

Development

Successfully merging this pull request may close these issues.

3 participants

@ermshiperete @mcdurdin @keyman-server