feat(core): expose km_core_state_options_update to WASM 🍪 🎼
#15438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part-of: #13426 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
km_core_state_options_update to WASMkm_core_state_options_update to WASM 🎼
ermshiperete
changed the title
km_core_state_options_update to WASM 🎼km_core_state_options_update to WASM 🍪 🎼
darcywong00
reviewed
Jan 16, 2026
| } | ||
|
|
||
| int | ||
| km_core_state_options_update_wasm( |
Contributor
There was a problem hiding this comment.
Does this get added to /core/docs/api/state.md?
(I dunno if that's the right doc)
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
We are not currently adding extra docs for _wasm versions of existing functions... but we could
mcdurdin
requested changes
Jan 18, 2026
| } | ||
|
|
||
| int | ||
| km_core_state_options_update_wasm( |
Member
There was a problem hiding this comment.
We are not currently adding extra docs for _wasm versions of existing functions... but we could
| km_core_state const *state, | ||
| const std::vector<km_core_option_item_wasm>& new_options | ||
| ) { | ||
| km_core_option_item* options_c = new km_core_option_item[new_options.size() + 1]; |
Member
There was a problem hiding this comment.
this needs to be freed at the end of the function
core/src/wasm.cpp
Outdated
| options_c[i].value = new_options[i].value.c_str(); | ||
| options_c[i].scope = new_options[i].scope; | ||
| } | ||
| options_c[new_options.size()] = {nullptr, nullptr, 0}; |
Member
There was a problem hiding this comment.
We have a constant for this:
Suggested change
| options_c[new_options.size()] = {nullptr, nullptr, 0}; | |
| options_c[new_options.size()] = KM_CORE_OPTIONS_END; |
Test-bot: skip
Contributor
Author
|
Baseline tests fail because the expiry time of cookies is set to the past. Will be fixed with #15472. |
ermshiperete
changed the base branch from
epic/web-core
to
fix/web/baselinetests
mcdurdin
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part-of: #13426
Test-bot: skip